[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] Fix crash on resolution change -> screen dump -

From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH] Fix crash on resolution change -> screen dump -> vga redraw
Date: Tue, 07 Apr 2009 15:56:47 -0500
User-agent: Thunderbird (X11/20090320)

Avi Kivity wrote:
The vga screen dump function updates last_width and last_height,
but does not change the DisplaySurface that these variables describe.
A consequent vga_draw_graphic() will therefore fail to resize the
surface and crash.

Fix by invalidating the display state after a screen dump, forcing
vga_draw_graphic() to reallocate the DisplaySurface.

Signed-off-by: Avi Kivity <address@hidden>

Applied.  Thanks.


Anthony Liguori

 hw/vga.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/vga.c b/hw/vga.c
index b1e4373..4d1049b 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -2678,4 +2678,5 @@ static void vga_screen_dump(void *opaque, const char 
         vga_screen_dump_graphic(s, filename);
         vga_screen_dump_text(s, filename);
+    vga_invalidate_display(s);


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]