Re: [Qemu-devel] [PATCH] 64 bit I/O support

[Tristan Gingold]

On Apr 9, 2009, at 1:53 AM, Robert Reif wrote:

> This patch is a rebase on current svn of my previous patch .
>
> This patch adds support for 64 bit I/O by essentially replacing an
> array of 4 function pointers with a structure containing 4 function
> pointers. The current array contains 4 pointers, one for 8, 16 and 32
> bit function pointers which really support only 32 bits and a
> forth pointer which is unused but I assume is a place holder for a
> 64 bit function pointer.  The current trick of passing 8, 16 or 32  
> bits
> in a 32 bit variable doesn't extend to passing 64 bits in a 32 bit
> bit variable and creating a 64 bit function would require casts to
> allow being saved in the array so a sutrcture is used that can take
> different function pointers.

Having a real 64 bit IO support is really useful for real 64 bit  
machines (sparc64, alpha...) as
the current emulation makes things more complex and is unable to catch  
some erroneous accesses.

So I strongly support this patch.

Tristan.