[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/7] net: Add VLAN client cleanup handler

From: Mark McLoughlin
Subject: Re: [Qemu-devel] [PATCH 2/7] net: Add VLAN client cleanup handler
Date: Wed, 15 Apr 2009 14:09:39 +0100

Hi Jan,

On Tue, 2009-04-14 at 19:29 +0200, Jan Kiszka wrote:
> Do proper VLAN client cleanup via a callback handler. This fixes
> resource leakage on host_net_remove and allows a generic net_cleanup
> implementation.

Yep, we need this.

However, I've got a different version in my queue (see below) - I've
been holding back on posting it until I finished some other patches I'm
working on, but I'll polish it off and post this afternoon.

Differences from yours include:

 - I've added cleanup code to all the NICs, including adding 
   unregister_savevm() so that we don't try and save deleted NICs

 - Rather than adding yet another param to new_vlan_client(), I just 
   initialize vc->cleanup after creating the client; another patch in
   my queue removes all callbacks to new_vlan_client() because as more
   are added it just gets terribly unwieldy.

 - I remove the io handler on e.g. the tapfd when freeing - otherwise 
   we'll continue to poll the fd AFAICS

 - I implement net_cleanup() by calling del_vlan_client() on all clients

Apart from that, the patches are very similar - are you okay with just
waiting for my patch?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]