[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [7146] Remove some useless malloc() checking (Mark McLoughl
From: |
Anthony Liguori |
Subject: |
[Qemu-devel] [7146] Remove some useless malloc() checking (Mark McLoughlin) |
Date: |
Fri, 17 Apr 2009 17:10:52 +0000 |
Revision: 7146
http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=7146
Author: aliguori
Date: 2009-04-17 17:10:51 +0000 (Fri, 17 Apr 2009)
Log Message:
-----------
Remove some useless malloc() checking (Mark McLoughlin)
Now that we abort() on malloc, neither qemu_find_vlan() nor
net_tap_fd_init() can fail.
Signed-off-by: Mark McLoughlin <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>
Modified Paths:
--------------
trunk/net.c
Modified: trunk/net.c
===================================================================
--- trunk/net.c 2009-04-17 17:10:47 UTC (rev 7145)
+++ trunk/net.c 2009-04-17 17:10:51 UTC (rev 7146)
@@ -1015,8 +1015,6 @@
return -1;
}
s = net_tap_fd_init(vlan, model, name, fd);
- if (!s)
- return -1;
snprintf(s->vc->info_str, sizeof(s->vc->info_str),
"ifname=%s,script=%s,downscript=%s",
ifname, setup_script, down_script);
@@ -1596,10 +1594,7 @@
vlan_id = strtol(buf, NULL, 0);
}
vlan = qemu_find_vlan(vlan_id);
- if (!vlan) {
- fprintf(stderr, "Could not create vlan %d\n", vlan_id);
- return -1;
- }
+
if (get_param_value(buf, sizeof(buf), "name", p)) {
name = strdup(buf);
}
@@ -1707,9 +1702,8 @@
if (get_param_value(buf, sizeof(buf), "fd", p) > 0) {
fd = strtol(buf, NULL, 0);
fcntl(fd, F_SETFL, O_NONBLOCK);
- ret = -1;
- if (net_tap_fd_init(vlan, device, name, fd))
- ret = 0;
+ net_tap_fd_init(vlan, device, name, fd);
+ ret = 0;
} else {
if (get_param_value(ifname, sizeof(ifname), "ifname", p) <= 0) {
ifname[0] = '\0';
@@ -1825,10 +1819,6 @@
VLANClientState *vc;
vlan = qemu_find_vlan(vlan_id);
- if (!vlan) {
- monitor_printf(mon, "can't find vlan %d\n", vlan_id);
- return;
- }
for(vc = vlan->first_client; vc != NULL; vc = vc->next)
if (!strcmp(vc->name, device))
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-devel] [7146] Remove some useless malloc() checking (Mark McLoughlin),
Anthony Liguori <=