[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting p

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH, RFC] Add file describing rules for submitting patches
Date: Mon, 20 Apr 2009 12:56:04 -0500
User-agent: Thunderbird (X11/20090320)

Blue Swirl wrote:
On 4/20/09, Anthony Liguori <address@hidden> wrote:
Blue Swirl wrote:


I gathered a few common complaints about patch submission, hopefully
not too much affected by my consumption of small amounts of various
alcoholic substances.

Comments, objections?

+SP4.1: It must be possible to apply the patch with quilt (equivalent
+to patch -p1) and "git am" without any editing or extra flags

 svn diff generates -p0 patches so both -p1 and -p0 should be accepted.

Quilt does not accept -p0 patches without extra work. Remember, the
idea is to reduce our burden, make it easier to test and apply

guilt does ;-)

FWIW, I'm working on getting the email commit script in place for the Savannah git repo. That's the last bit needed to switch from svn -> git.

After that, a git-send-email requirement (or equiv) would make a lot of sense as it significantly reduces the maintainers work via git-am.


Anthony Liguori

Diff can generate other types of diffs besides the unified type but we
don't want any other.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]