[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [patch 05/14] qemu: factor out special event notificati

From: Anthony Liguori
Subject: Re: [Qemu-devel] [patch 05/14] qemu: factor out special event notification
Date: Wed, 22 Apr 2009 15:58:35 -0500
User-agent: Thunderbird (X11/20090320)

address@hidden wrote:
Special events that have no particular event descriptor (either fd for UNIX
or HANDLE for Windows) associated with make use of an artificial one.

Signed-off-by: Marcelo Tosatti <address@hidden>

Index: trunk/vl.c
--- trunk.orig/vl.c
+++ trunk/vl.c
@@ -921,15 +921,11 @@ static void qemu_rearm_alarm_timer(struc
 #define MIN_TIMER_REARM_US 250
static struct qemu_alarm_timer *alarm_timer;
-#ifndef _WIN32
-static int alarm_timer_rfd, alarm_timer_wfd;
#ifdef _WIN32 struct qemu_alarm_win32 {
     MMRESULT timerId;
-    HANDLE host_alarm;
     unsigned int period;
 } alarm_win32_data = {0, NULL, -1};

There are a number of spots in vl.c that do CloseHandle(data->host_alarm) that aren't removed in this patch. For instance, the error path in win32_start_timer().


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]