[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH, RFC] Smarter compilation for target devices
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH, RFC] Smarter compilation for target devices |
Date: |
Tue, 28 Apr 2009 14:32:41 +0100 |
User-agent: |
KMail/1.9.9 |
> Compile target devices only once for each endian and word size combination,
> saving a few compiles if large number of targets are enabled.
> +CPPFLAGS=-I. -I.. -I$(SRC_PATH) -MMD -MT $@ -MP -DNEED_CPU_H
> +# Warning: Do not add new files here if they have conditional code
> +# with #ifdef TARGET_xxx etc, use TARGET_PAGE_SIZE or reference
> +# CPUState
This is just asking for trouble. Anything that includes cpu.h must be rebuilt
for every cpu. IMO a necessary prerequisite for this change is reworking
header files so that you can't accidentally use the wrong symbols.
Also, which bitwidth are you intending to distinguish here? target_ulong or
target_phys_addr_t? With a few exceptions, devices don't care about the
former. Duplicating this logic is both cpu.h and configure is also asking for
trouble. At minimum the build should fail if they disagree.
Paul