qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c into


From: François Revol
Subject: Re: *** GMX Spamverdacht *** [Qemu-devel] [PATCH] Merge usb-wacom.c into usb-hid.c
Date: Wed, 29 Apr 2009 11:30:29 +0200 CEST

> > > > http://thread.gmane.org/gmane.comp.emulators.qemu/40232/focus=40233
> > > > > > >
> > > Reading something like this in a Git log, sitting 30k feet above
> > > ground, makes me want to do something very foolish.
>
> To illustrate what commit messages in typical Git repositories look
> like:
>
> http://repo.or.cz/w/git.git?a=commitdiff;h=8d2dfc49b199c7da6faefd7993630f24bd37fee0
> >
> (answering a link with a link is okay, I think.)

Typical commit line counts in QEMU tends to be quite lower :

# count lines
$ git log | awk '/^    ..*$/{cnt++;/*print*/};NR>1&&/^commit/{print
cnt; cnt="0"}' | sort -g | uniq -c | sort -g -k 1 -r
   4904 2
    798 3
    354 4
    255 5
    239 6
    172 7
    103 8
     85 9
     59 10
     36 12
     33 11
     28 13
     21 14
     15 18
     14 15
      9 16
      9 1
      6 21
      6 20
      5 17
      4 25
      4 23
      3 24
      2 37
      2 31
      2 26
      2 19
      1 68
      1 62
      1 59
      1 41
      1 38
      1 36
      1 35
      1 34
      1 33
      1 32

Which isn't a problem in itself...

> The point is that nobody needs to sift through long and dispersed
> discussions with a lot of points that are moot in the end.  If more
> than
> one person reads the summary of the discussions in the commit
> message, the
> overall saved time (integrated over all involved people) is
> substantial.

The problem is everytime I've spent time explaining the patch, like 2
ppl read it and gave thoughtfull comments. Which should be enough but I
just got fed up spending hours ingurGITating man pages.

Besides, you still didn't even comment on the patch itself yet, which
quites asserts this.

François.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]