[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management |
Date: |
Wed, 29 Apr 2009 13:36:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Liu Yu-B13201 wrote:
>> -----Original Message-----
>> From: Jan Kiszka [mailto:address@hidden
>> Sent: Wednesday, April 29, 2009 6:38 PM
>> To: Liu Yu-B13201
>> Cc: address@hidden; address@hidden
>> Subject: Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks
>> to slot management
>>
>> Liu Yu-B13201 wrote:
>>>> -----Original Message-----
>>>> From: address@hidden
>>>> [mailto:address@hidden
>>>> On Behalf Of Jan Kiszka
>>>> Sent: Sunday, April 12, 2009 1:20 AM
>>>> To: address@hidden
>>>> Subject: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to
>>>> slot management
>>>>
>>>> Fail loudly if we run out of memory slot.
>>>>
>>>> Make sure that dirty log start/stop works with consistent
>>>> memory regions
>>>> by reporting invalid parameters. This reveals several
>>>> inconsistencies in
>>>> the vga code, patch to fix them follows later in this series.
>>>>
>>>> And, for simplicity reasons, also catch and report unaligned memory
>>>> regions passed to kvm_set_phys_mem (KVM works on page basis).
>>>>
>>> Commit d3f8d37fe2d0c24ec8bac9c94d5b0e2dc09c0d2a hurts kvm/powerpc
>>> The alignment check in kvm_set_phys_mem prevents pci
>> controller and mpic initializing mmio regions.
>>
>> What is the alignment of those regions then? None?
>> And do regions of
>> different types overlap even on the same page?
> I think so.
>
>> Maybe the check reveals
>> some deeper conflict /wrt KVM. Can you point me to the
>> involved code files?
>>
>
> hw/ppc4xx_pci.c ppc4xx_pci_init()
> hw/ppce500_pci.c ppce500_pci_init()
> hw/openpic.c mpic_init()
> hw/ppce500_mpc8544ds.c serial_mm_init()
>
Hmm, too bad that I have no platform at hand to test this. Could you
instrument kvm_set_phys_mem (on an older, working version), dumping its
arguments and post this trace?
TIA,
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
- [Qemu-devel] [PATCH 1/7] kvm: Sync CPU state on reset, (continued)
- [Qemu-devel] [PATCH 1/7] kvm: Sync CPU state on reset, Jan Kiszka, 2009/04/11
- [Qemu-devel] [PATCH 6/7] vga: Fix inconsistent tracking of map_addr, Jan Kiszka, 2009/04/11
- [Qemu-devel] [PATCH 2/7] kvm: Apply SMM-already-initialized workaround on reset, Jan Kiszka, 2009/04/11
- [Qemu-devel] [PATCH 7/7] vga: Cleanup dirty logging, Jan Kiszka, 2009/04/11
- [Qemu-devel] [PATCH 3/7] kvm: Cleanup unmap condition in kvm_set_phys_mem, Jan Kiszka, 2009/04/11
- [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management, Jan Kiszka, 2009/04/11
- RE: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management, Liu Yu-B13201, 2009/04/29
- Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management, Hollis Blanchard, 2009/04/29
- Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management, Jan Kiszka, 2009/04/29
- Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management, Hollis Blanchard, 2009/04/29
- Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management, Jan Kiszka, 2009/04/29
- RE: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management, Liu Yu-B13201, 2009/04/29
- Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management, Anthony Liguori, 2009/04/29
- Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management, Hollis Blanchard, 2009/04/29
- Re: [Qemu-devel] [PATCH 4/7] kvm: Add sanity checks to slot management, Blue Swirl, 2009/04/29
Re: [Qemu-devel] [PATCH 0/7] kvm: fix system reset & rework slot management, Anthony Liguori, 2009/04/17