[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH 10/10] Return EOPNOTSUPP instead of ENOSYS for *xatt

From: riku . voipio
Subject: [Qemu-devel] [PATCH 10/10] Return EOPNOTSUPP instead of ENOSYS for *xattr* syscalls
Date: Wed, 29 Apr 2009 21:03:23 +0300

From: Arnaud Patard <address@hidden>

In current code, we're sending ENOSYS to target when a syscall for the
xattrs is done. This makes applications like ls complain loudly about
that and breaks scripts parsing the output. Moreover, iirc, implemented
features of filesystems are are sending EOPNOTSUPP (I've not checked so
I may be a little bit wrong on that...).
So, I'm proposing to return -EOPNOTSUPP and make ls happy

From: Arnaud Patard <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>
 linux-user/syscall.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index be00c7e..183f852 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -6577,7 +6577,8 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
     case TARGET_NR_removexattr:
     case TARGET_NR_lremovexattr:
     case TARGET_NR_fremovexattr:
-        goto unimplemented_nowarn;
+        ret = -TARGET_EOPNOTSUPP;
+        break;
 #ifdef TARGET_NR_set_thread_area
     case TARGET_NR_set_thread_area:

reply via email to

[Prev in Thread] Current Thread [Next in Thread]