[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3

From: Anthony Liguori
Subject: Re: [Qemu-devel] PATCH: enabling TCP keepalives - v3
Date: Fri, 01 May 2009 10:57:24 -0500
User-agent: Thunderbird (X11/20090320)

Paul Brook wrote:
On Friday 01 May 2009, Anthony Liguori wrote:
David Ahern wrote:
Missed that. Forgot to add net.h to vnc.c.

Before I re-send a patch, what's the feeling regarding enabling this all
the time versus a command line option to control it?

I'm on the fence.  It's not something I think is extremely common and it
seems like we're going to great lengths to fix up one persons broken

I'm wary of enabling this by default. As someone else mentioned, having your TCP console connections spontaneously combust after 60 seconds can be somewhat surprising.

An option seems reasonable enough. We already have this for nodelay.

I don't think an option is very useful. If you lose your connection and now have a bunch of orphan connections, it's too late to have the foresight to have used an option on startup. In that case, it would be much better to just be able to close existing connections.

I think there's a very, very small number of people that would have the foresight to always use keepalive=60 or whatever the option would be.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]