Re: [Qemu-devel] [PATCH] Add HTTP protocol using curl v2

[Anthony Liguori]

Kevin Wolf wrote:
> Daniel P. Berrange schrieb:
>   
> > All I care about from libvirt POV, is that there is a way to give QEMU an 
> > absolute file path for a disk, and guarentee that QEMU will treat this as
> > a local file path, and not try any access protocols, other than 'open(2)'.
> > Various options from this thread....
> >
> >  - Treat any path starting with / as local file
> >  - Allow file:  as a prefix
> >  - Allow file:/// as a prefix, real URI style
> >  - Add a protocol=file  flag to -drive
> >
> > Pick one, pick several, suggest more. Any of these options would work as 
> > far as I'm concerned, and we could easily support several. I think the
> > first is desirable because that's the natural thing users will try when
> > launching QEMU directly.
> >     
>
> I think we all agree that file: is a reasonable option for libvirt which
> covers all cases of colons (even relative paths starting with http:), so
> let's take this one. If you want to magically do the right thing for
> users invoking qemu manually, I think we should rather go for:
>   

I've changed my mind.  I think file: makes the situation worse because 
it gives a false sense of security.  If you just pass 
file:<user-inputed-filename> you are broken.  You still have to escape 
commas.  If you're escaping commas, you might as well escape colons too.

I think escaping is the only complete solution.

Regards,

Anthony Liguori