[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [patch] fix qemu-kvm to build when gdbstub is disabled
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [patch] fix qemu-kvm to build when gdbstub is disabled |
Date: |
Thu, 07 May 2009 13:13:59 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Avi Kivity wrote:
> Jan Kiszka wrote:
>>> In upstream. Please fix it in upstream and qemu-kvm.git will get the
>>> fix from there.
>>>
>>
>> Given that CONFIG_GDBSTUB is always true upstream, I tend to say:
>> Finally drop it upstream and keep this (or a more arch-local) workaround
>> for missing ia64 gdbstub support downstream.
>>
>
> I agree, unless
>
> - we want to make gdbstub support configurable (don't see any
> overwhelming reason for this, but maybe others do)
> - we want to merge ia64 kvm support upstream, and don't want to impose
> gdbstub support (though I'd recommend properly implementing gdbstub)
>
> In any case, I'm okay with dropping the check upstream and applying the
> local fixup.
The last ia64 tcg patch I saw one or two days ago was missing gdb
support, too (and may suffer from some brokenness for that reason). But
I would suggest for both cases (tcg and kvm) to temporarily provide
stubs/placeholders instead of keeping the central #ifdefs.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux