[Qemu-devel] Re: [Qemu-commits] [COMMIT aae9460] Basic qdev infrastructure.

[Blue Swirl]

On 5/15/09, Anthony Liguori <address@hidden> wrote:
> From: Paul Brook <address@hidden>
>
>  Signed-off-by: Paul Brook <address@hidden>

>  +struct DeviceProperty {
>  +    const char *name;
>  +    union {
>  +        int i;

qdev_set_prop_int uses also 'int' but qdev_get_prop_int returns uint64_t.

>  +struct DeviceType {
>  +    const char *name;
>  +    qdev_initfn init;
>  +    void *opaque;
>  +    int size;

size_t size?

>  +DeviceType *qdev_register(const char *name, int size, qdev_initfn init,
>  +                          void *opaque)

size_t size?

>  +void qdev_set_prop_int(DeviceState *dev, const char *name, int value)

>  +uint64_t qdev_get_prop_int(DeviceState *dev, const char *name, uint64_t def)