[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 1/4] Add GPL bios as a submodule

From: Avi Kivity
Subject: [Qemu-devel] Re: [PATCH 1/4] Add GPL bios as a submodule
Date: Sun, 17 May 2009 18:43:00 +0300
User-agent: Thunderbird (X11/20090320)

Anthony Liguori wrote:
Signed-off-by: Anthony Liguori <address@hidden>
 .gitmodules  |    3 +++
 roms/gplbios |    1 +
 2 files changed, 4 insertions(+), 0 deletions(-)
 create mode 100644 .gitmodules
 create mode 160000 roms/gplbios

diff --git a/.gitmodules b/.gitmodules
new file mode 100644
index 0000000..9bdf196
--- /dev/null
+++ b/.gitmodules
@@ -0,0 +1,3 @@
+[submodule "roms/gplbios"]
+       path = roms/gplbios
+       url = git://repo.or.cz/gplbios/qemu.git

I really prefer a relative path here, so that people can set up mirrors on an internal server. Also, not everyone can access the git port. It can be worked around, but it's much better to have things working out of the proverbial box.

Also, s/roms/firmware/ to be modern.

Having said all that, I'd rather see seabios here. Sure, it will take us time to add missing features, if any, but life will be much more pleasant afterwards. We should reduce our ties to the bochs bios, not tighten them.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]