[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/11] qemu: helper routines for pci access.
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH 04/11] qemu: helper routines for pci access. |
Date: |
Tue, 26 May 2009 09:41:52 +0300 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, May 26, 2009 at 11:33:37AM +0900, Isaku Yamahata wrote:
> On Mon, May 25, 2009 at 03:25:33PM +0300, Michael S. Tsirkin wrote:
> > Add inline routines for convenient access to pci devices
> > with correct (little) endianness. Will be used by MSI-X support.
>
> Just a minor comment.
> How about to add pci_[sg]et_byte() for consistency?
I don't see that it makes sense - pci_set_long(config, value)
is shorter than *((uint32_t *)config) = cpu_to_le32(value),
but single bytes don't have endianness, and *config = value
is shorter.
--
MST