Re: [Qemu-devel] [PATCH 2/2] Add serial number support for virtio_blk, V3

[john cooper]

Christoph Hellwig wrote:
> On Wed, May 27, 2009 at 09:49:19AM +0200, Christoph Hellwig wrote:
>> /*
>>  * IDE-compatible identify ioctl.
>>  *
>>  * Currenlyt only returns the serial number and leaves all other fields
>>  * zero.
>>  */
> 
> Btw, thinking about it the rest of the information in the ioctl should
> probably be filled up with faked data, similar to how we do it for
> the ide emulation inside qemu.

Agreed.  I've done so to the extent it makes sense
in the case of the more generic fields.  A fair
amount of the identify information being generated
by hw/ide.c appears obsoleted.

-john

-- 
address@hidden