[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] Change virtio-console to PCI_CLASS_SERIAL_OTHER

From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH] Change virtio-console to PCI_CLASS_SERIAL_OTHER
Date: Fri, 29 May 2009 04:55:20 -0500
User-agent: Thunderbird (X11/20090409)

Mark McLoughlin wrote:
> The more I think about it, no matter how much linear ABI versioning
> sucks, it's possibly the only way to solve this in a reasonably usable
> manners. Distros would just have to suck it up and agree that if they
> cherry-pick an ABI changing patch, they must update the entire ABI to
> the newer upstream ABI version.

If we modify pci_qdev_register() to take the savevm functions and pass
the qdev to each handler as a convention, we could then leverage the
version id of the device to implement the device versioning logic.  We
would also be able to query what the current versions are in the monitor.

Moreover, we could walk the device tree before savevm to validate that
every device in the tree supports savevm which means we can fail
gracefully in when the chosen device model doesn't support live migration.

It's a large refactoring, but mostly mechanical.  Any takers?


Anthony Liguori

> Cheers,
> Mark.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]