[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Disable kqemu by default
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH] Disable kqemu by default |
Date: |
Fri, 29 May 2009 13:40:44 +0100 |
User-agent: |
Mutt/1.4.1i |
On Fri, May 29, 2009 at 09:30:47AM -0300, Glauber Costa wrote:
> On Fri, May 29, 2009 at 02:22:47PM +0200, Tomasz Chmielewski wrote:
> > Glauber Costa wrote:
> >> turns -no-kqemu option into -kqemu
> >> set kqemu_allowed to 0 by default.
> >
> > (...)
> >
> >> #ifdef CONFIG_KQEMU
> >> -DEF("no-kqemu", 0, QEMU_OPTION_no_kqemu, \
> >> - "-no-kqemu disable KQEMU kernel module usage\n")
> >> +DEF("-kqemu", 0, QEMU_OPTION_kqemu, \
> >> + "-kqemu enable KQEMU kernel module usage\n")
> >
> > Why is this change needed?
> Well, we certainly need a -kqemu option to enable it, if it is disabled by
> default.
>
> >
> > Even if changed, wouldn't it be better to leave the -no-kqemu option for
> > compatibility reasons? Otherwise, current scripts may break.
> options comes and go every day.
>
> but it's not a big burden, we can leave the old option around...
How about we add an option that's more future proof.
eg,
--accel qemu|kvm|kqemu|xen
if that isn't given, then it'd pick the 'best', use --accel XXX to
override the auto behaviour
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
[Qemu-devel] Re: [PATCH] Disable kqemu by default, Jan Kiszka, 2009/05/30