[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h |
Date: |
Tue, 09 Jun 2009 18:17:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Glauber Costa wrote:
> Following a suggestion given by Jan, the idea here is to
> move shared pieces between qemu and qemu-kvm.git into a common
> file, so we can do sharing while avoid clashes.
>
> In the future, this files should disappear.
>
OK for the header - but why do we have to push the ioctl services into a
separate module? Will all functions qemu-kvm start to use from upstream
have to be pushed around? Or what is special about the ioctls?
I rather think qemu-kvm should build kvm-all.c and #ifdef out those
parts which collide with its own implementation. Moreover, when we morph
qemu-kvm services for upstream, this could already happen where they
shall once be located: in kvm-all.c or target-*/kvm.c.
Jan
--
Siemens AG, Corporate Technology, CT SE 2
Corporate Competence Center Embedded Linux
- [Qemu-devel] [PATCH] create kvm-shared-all.c and kvm-shared.h, Glauber Costa, 2009/06/09
- [Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h,
Jan Kiszka <=
- Re: [Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h, Avi Kivity, 2009/06/09
- Re: [Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h, Glauber Costa, 2009/06/09
- Re: [Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h, Avi Kivity, 2009/06/09
- Re: [Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h, Jan Kiszka, 2009/06/09
- Re: [Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h, Glauber Costa, 2009/06/09
- Re: [Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h, Jan Kiszka, 2009/06/09
[Qemu-devel] Re: [PATCH] create kvm-shared-all.c and kvm-shared.h, Glauber Costa, 2009/06/09