[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix "defined but not used" warning
|
From: |
Marcelo Tosatti |
|
Subject: |
Re: [Qemu-devel] [PATCH] Fix "defined but not used" warning |
|
Date: |
Tue, 9 Jun 2009 21:30:02 -0300 |
|
User-agent: |
Mutt/1.5.19 (2009-01-05) |
On Tue, Jun 09, 2009 at 06:24:57PM -0300, Luiz Capitulino wrote:
>
> The function qemu_calculate_timeout() is only used when CONFIG_IOTHREAD
> is not defined. When CONFIG_IOTHREAD is defined, we have the following
> warning:
>
> vl.c:4389: warning: ‘qemu_calculate_timeout’ defined but not used
>
> This change fixes that by moving the #ifdef/#endif from main_loop()
> into qemu_calculate_timeout(). This encapsulates the logic and allow
> us to use qemu_calculate_timeout() when CONFIG_IOTHREAD is defined
> or not (suggested by Glauber Costa).
ACK