[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/4] Add device tree machine
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] [PATCH 2/4] Add device tree machine |
Date: |
Thu, 11 Jun 2009 14:39:25 +0100 |
User-agent: |
KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; ) |
On Thursday 11 June 2009, Gerd Hoffmann wrote:
> A few more comments ...
>
> > +static void dt_add_props(DeviceState *dev, void *dt, int offset)
> > +{
>
> Where do device properties come from? Only the fdt tree? If so, do we
> need the property lists in the first place? We could get them directly
> from the fdt tree instead.
The FDT doesn't contain any type information. My initial implementation
omitted DevicePropertyList altogether. That ended up fairly messy. Also, when
we're using the same tree for both qemu and linux the tree probably has
additional properties we don't care about.
Paul
[Qemu-devel] [PATCH 2/4] Add device tree machine, Paul Brook, 2009/06/10
Re: [Qemu-devel] [PATCH 2/4] Add device tree machine, Markus Armbruster, 2009/06/12
[Qemu-devel] [PATCH 3/4] Stellaris machine config, Paul Brook, 2009/06/10
[Qemu-devel] [PATCH 4/4] Integrator machine config, Paul Brook, 2009/06/10