[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option

From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH] Add -no-virtio-balloon command-line option
Date: Mon, 15 Jun 2009 07:54:19 -0500
User-agent: Thunderbird (X11/20090320)

Markus Armbruster wrote:
Dor Laor <address@hidden> writes:

Gerd Hoffmann wrote:
This new option may be used to disable the virtio-balloon device.

ACK, looks good.

And I can drop my lazy patch which just comments out virtio-balloon
in the code ;)
Actually, I rather have the balloon disabled by default. It's like any
other pci device which needs
explicit command line specification. Why consume a pci slot if not
implicitly required?

I agree.  The command line is plenty magic without implicitly added
PCI devices.

Besides, negative options -no-virtio-balloon lead to ugly
double-negatives like if (!no_virtio_balloon).

It does no harm to add the device by default so why force the user to explicitly enable it?


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]