[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCHv4 01/13] qemu: make default_write_config use mas
Michael S. Tsirkin
[Qemu-devel] Re: [PATCHv4 01/13] qemu: make default_write_config use mask table
Wed, 17 Jun 2009 14:49:42 +0300
On Tue, Jun 16, 2009 at 03:40:13PM -0500, Anthony Liguori wrote:
> Michael S. Tsirkin wrote:
>> Change much of hw/pci to use symbolic constants and a table-driven
>> design: add a mask table with writable bits set and readonly bits unset.
>> Detect change by comparing original and new registers.
>> This makes it easy to support capabilities where read-only/writeable
>> bit layout differs between devices, depending on capabilities present.
>> As a result, writing a single byte in BAR registers now works as
>> it should. Writing to upper limit registers in the bridge
>> also works as it should. Code is also shorter.
>> Signed-off-by: Michael S. Tsirkin <address@hidden>
> This series introduces warning (virtio_load decl/def does not match).
Seems to match and build cleanly with -Werror for me.
What warning do you see?