[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] avoid compilation warning/errors on up to da
Re: [Qemu-devel] [PATCH v3] avoid compilation warning/errors on up to date compilers/glibc
Wed, 17 Jun 2009 15:03:51 +0100
KMail/1.11.4 (Linux/2.6.29-2-amd64; KDE/4.2.4; x86_64; ; )
> > This is no more correct than before. read() can return EINTR and that
> > should be handled appropriately. Elsewhere, read() can return partial
> > results and we ought to handle that properly.
> It handles all cases except EINTR. And in the actual code base EINTR and
> __all other__ error cases are not handled. So as of today EINTR is not
> handled propely (as well as all other error cases). So this consider EINTR
> as an error when it could be handled in a nicer way. Previously no ERRORS
> were considered as an error. What is best?
The original is the lesser wevil because it is obviously wrong. Your patch
looks like it does error handling and avoids generates warnings, but still
does not work correctty.
> > Using -D_FORTIFY_SOURCES=0 will eliminate these warnings. If we're
> > going to fix these things, we should fix them properly.
> It just hides the problem and fix nothing but the compilation.
Your patch just makes the bug more subtle and harder to spot.