[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH] warnings in net.c
|
From: |
Jan Kiszka |
|
Subject: |
[Qemu-devel] Re: [PATCH] warnings in net.c |
|
Date: |
Thu, 18 Jun 2009 20:31:56 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
Ulrich Hecht wrote:
> On Wednesday 17 June 2009, Filip Navara wrote:
>> On Wed, Jun 17, 2009 at 5:47 PM, Ulrich Hecht <address@hidden> wrote:
>>> removes unused slirp code and initializes ret in net_client_init()
>>>
>>> Signed-off-by: Ulrich Hecht <address@hidden>
>> It is definitely not unused when CONFIG_SLIRP is defined. I'm damn
>> sure I use the code and that I was debugging it two days ago.
>
> Er, yes, now that you mention it... I even grepped for net_client_init,
> but I didn't find it.
>
> Still, it dies thanks to -Werror with a plain "./configure". I guess
> framing it with #ifdef CONFIG_SLIRP will do.
It _is_ already framed, and it _does_ build flawlessly with
--disable-slirp here. You must be looking at a different version.
Jan
signature.asc
Description: OpenPGP digital signature