Re: [Qemu-devel] [PATCH v4] avoid compilation warning/errors on up to date

[Anthony Liguori]

Luiz Capitulino wrote:
> On Thu, 18 Jun 2009 01:16:37 +0200
> "Jean-Christophe Dubois" <address@hidden> wrote:
>
>   
> > And whatever I have added is a lot more robust than what was before.
> > Once again, please just show me where my patch is incorrect and I
> > will fix it. 
> >     
>
>  I really missed this v4, sorry for that and thanks for letting me know.
>
>  I think the first step is to do one logical change at a time. You
> could, for example do:
>
>  1. Add qemu_read() and qemu_write()
>   

We already have these in various places.  The problem is, we often want 
different semantics.  We don't always want to retry partial results 
(like for live migration).  We need a more rationalized approach to this.

>  2. Port one subsystem per-patch for each of them
>   

Yes, and for each fixup, fix the whole function, not just a handful of 
functions that gcc currently whines about.

N.B.  I will be pushing -U_FORTIFY_SOURCE so the ubuntu build breakage 
will be fixed.  We have the time to fix these warnings correctly.

Regards,

Anthony Liguori