[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] cocoa.m issues fixed

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH] cocoa.m issues fixed
Date: Sun, 21 Jun 2009 18:23:29 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 06/21/2009 05:06 PM, G 3 wrote:

On Jun 21, 2009, at 6:10 AM, Andreas Färber wrote:

Am 21.06.2009 um 03:19 schrieb G 3:

+int cocoa_keycode_to_qemu(int keycode);

This seems unrelated. I believe you're trying to suppress a warning I've been seeing on 10.5 as well - if so, please provide that as a separate patch with appropriate description.

This function prototype would eliminate this warning:
cocoa.m:233: warning: no previous prototype for `cocoa_keycode_to_qemu'

Why a separate patch. Why not kill two birds with one stone?

It's standard operating procedure. Suppose in addition to the two birds you mention the patch also kills an innocent kitten. Since it's one patch, if a fix is not immediately forthcoming, the maintainer has to revert the patch, bringing both birds back to life.

With one patch per bird, the maintainer can revert just the patch which killed the kitten, leaving the other bird dead.

It's also easier to review two small patches rather than one large patch.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]