[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them?

From: Avi Kivity
Subject: Re: [Qemu-devel] [POLL] slirp statistics - enable or drop them?
Date: Mon, 22 Jun 2009 15:36:54 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 06/22/2009 03:28 PM, Jan Kiszka wrote:
I just broke (locally) the slirp statistics. You know: "info slirp".
Maybe you don't because they are off by default, and there is even no
hidden configure switch to enable them ("#define LOG_ENABLED" or
"-DLOG_ENABLED" is required). Before fixing them again, I wonder if
there are actually use cases out there.

Basically I have three options now:

  - drop them completely (would make my nice, 1600-lines dropping slirp
    cleanup patch even nicer...)
  - fix them and leave them disabled, maybe adding some
    --enable-slirpstats to configure
  - fix them, but turn them on by default again so that Joe User is able
    to, well, actually look at them

Feedback appreciated.

I don't see the need for slirp stats. A production deployment is not going to use slirp, and a developer deployment won't need slirp stats.

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]