qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/11] QMP: Make monitor_handle_command() QMP aw


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 04/11] QMP: Make monitor_handle_command() QMP aware
Date: Tue, 23 Jun 2009 08:51:16 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Luiz Capitulino wrote:
Two changes are needed in monitor_handle_command() so that it
knows how to work in control mode.

First, it has to know whether a given command is part of the
protocol or not. Second, it has to print the correct server
response when a command execution finishes.

A good approach to do this would be:

1. Add a new member to struct mon_cmd_t, which will tell if
the command is already part of the protocol.

2. Change handler_* functions to return exit status, so that
monitor_handle_command() can print "+ OK" or "- ERR"
accordling.
These changes are a requirement for merging.

Regards,

Anthony Liguori




reply via email to

[Prev in Thread] Current Thread [Next in Thread]