qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/11] QMP: Introduce specification file


From: Anthony Liguori
Subject: Re: [Qemu-devel] [PATCH 01/11] QMP: Introduce specification file
Date: Tue, 23 Jun 2009 13:32:37 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Avi Kivity wrote:

An RPC makes it a lot easier for clients to parse, there's no need for a regular expression per command, or to bother with line continuations etc. You just focus on the data.

We have an opportunity to make a clean break, let's make use of it.

If we structure things internally correctly, by having a flow that basically looks like:

int <monitor_command>(Monitor *mon, <args>)
{
  // process args
  if (success) {
      monitor_print_data(mon, <highly structured output>);
   } else {
      record_extended_error(<message>);
      return error_code;
   }
}

Then it that works well for both the human monitor and the computer monitor. It's an RPC though.

Should we support other types of RPCs? I don't know. I'd think that you could create a computer monitor -> jsonrpc bridge easily enough.

If we implement this correctly, then an RPC interface could just be another option to see the computer monitor mode implemented as a "module".

I don't want to invent Xen-API here and go through that pain in QEMU.

I don't see the parallel.

Xen-API was the "clean break" for Xend.

--
Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]