|
| From: | Avi Kivity |
| Subject: | Re: [Qemu-devel] [PATCH] block: Clean up after deleting BHs |
| Date: | Tue, 23 Jun 2009 22:50:43 +0300 |
| User-agent: | Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 |
On 06/23/2009 10:41 PM, Christoph Hellwig wrote:
On Tue, Jun 23, 2009 at 09:31:55PM +0300, Avi Kivity wrote:I meant in an omg we have to look at all the consequences way rather than byte count. This patch is somewhat less local.My patch makes sure a re-used acb is in the same state as a newly allocated one. I think that's much more sensible than messing around with some state during freeing some acbs.
What if it has pointers to allocated stuff it was planning to reuse? You're leaking memory.
-- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.
| [Prev in Thread] | Current Thread | [Next in Thread] |