Re: [Qemu-devel] the qemu-iotests test suite is now available

[Kevin Wolf]

Christoph Hellwig schrieb:
> On Tue, Jun 23, 2009 at 04:36:29PM +0200, Kevin Wolf wrote:
>> Christoph Hellwig schrieb:
>>> On Tue, Jun 23, 2009 at 11:16:21AM +0200, Kevin Wolf wrote:
>>>> About the qcow2 tests there is one thing to note: These test cases use
>>>> hard coded offsets which were calculated for 4k clusters. For 64k
>>>> clusters (which the default now) I'm almost sure they don't test the
>>>> critical points any more. So we'll need to change offsets dynamically
>>>> depending on the cluster size of the qcow2 image.
>>> Or just run the test for all interesting cluster sizes to some more
>>> coverage (should be only 4k and 64k for now).
>> We could either always test both 4k and 64k or let the user choose on
>> the command line. Either way, this is unrelated to what I meant. I'm
>> talking about things like this:
>>
>>     # Spanning multiple clusters
>>     io $op $((offset + 2048)) 8192 12288 64
>>
>> This is a request spanning multiple 4k clusters, but for 64k clusters it
>> is just another write somewhere in the middle of the cluster. So with
>> 64k we actually have worse coverage currently than with 4k clusters (and
>> we don't test 4k yet).
> 
> Yes, that needs updates for the 64k clusters.  Do you already have an
> updated version?  If not I'll walk through it once I'm done here with
> FISL.

No, not yet. If you like I can try to patch it in, but maybe at this
point you know best how options like varying cluster size fit best in
the code. Don't know how much you care about your design. ;-)

Kevin