[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ATAPI pass through
|
From: |
Christoph Hellwig |
|
Subject: |
Re: [Qemu-devel] [PATCH] ATAPI pass through |
|
Date: |
Wed, 1 Jul 2009 10:44:59 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Wed, Jul 01, 2009 at 08:57:37AM +0200, Alexander Graf wrote:
> But last time I checked, we had a cdrom emulation in scsi-disk.c _and_
> in ide.c.
>
> I personally see no reason for that. Why can't we just have an atapi
> emulation layer in ide.c and use whatever scsi backends we have? That
> way, we'd only need to implement cd-rom and scsi passthrough once and
> have it available either via SCSI or via ATAPI.
That would be best. Note that we don't implement SCSI passthrough in
scsi-disk.c but rather in scsi-generic.c. But being able to attach
both of them to ata.c using an ATAPI shim would indeed be best.