[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [Qemu-commits] [COMMIT 059b8b1] KVM: x86: Refactor pers
From: |
Blue Swirl |
Subject: |
[Qemu-devel] Re: [Qemu-commits] [COMMIT 059b8b1] KVM: x86: Refactor persistent CPU state |
Date: |
Wed, 1 Jul 2009 23:10:15 +0300 |
On 7/1/09, Jan Kiszka <address@hidden> wrote:
> Anthony Liguori wrote:
> > Blue Swirl wrote:
> >> On 6/30/09, Anthony Liguori <address@hidden> wrote:
> >>
> >>> From: Jan Kiszka <address@hidden>
> >>>
> >>> This patch aligns the KVM-related layout and encoding of the CPU state
> >>> to be saved to disk or migrated with qemu-kvm. The major differences
> >>> are
> >>> reordering of fields and a compressed interrupt_bitmap into a single
> >>> number as there can be no more than one pending IRQ at a time.
> >>>
> >>> Signed-off-by: Jan Kiszka <address@hidden>
> >>> Signed-off-by: Anthony Liguori <address@hidden>
> >>>
> >>
> >>
> >>> + for (i = 0; i < ARRAY_SIZE(env->interrupt_bitmap); i++) {
> >>> + bit = ffsll(env->interrupt_bitmap[i]);
> >>>
> >>
> >> This broke build on platforms without ffsll (Mingw32, *BSDs).
> >>
> >
> > What version of mingw32? Mine seems to have ffsll (gcc 4.4.2).
> >
> > Jan, can you send a patch to fix this?
> >
>
>
> I'm currently checking the mingw situation. I likely missed the warning,
> but it seems to link - looking for the header...
>
> Can anyone comment on the BSD situation? I have no test env for such
> platforms.
Grepping for ffsll in /usr/include does not find anything, there is no
man page either.
We could add a local qemu_ffsll (or qemu_ffs64) to osdep.c or cutils.c.