Re: [Qemu-devel] [PATCH] Replace signrom with shell script v3

[Alexander Graf]

On 02.07.2009, at 21:02, Anthony Liguori wrote:

> Blue Swirl wrote:
> > On 7/2/09, Blue Swirl <address@hidden> wrote:
> >
> > > On 7/1/09, Alexander Graf <address@hidden> wrote:
> > > > In order to not execute code we just compiled, let's replace  
> > > signrom
> > > >  with a shell script that does the same thing while staying  
> > > compatible
> > > >  to pretty much every system available.
> > > >
> > > >  This should make cross-compilation for windows easier.
> > >
> > >
> > > Why don't you use $(HOST_CC) to compile the signrom binary?
> >
> > Like with this patch? Fixes Mingw32 compile for me.
>
> If you're cross compiling, HOST_CC is the wrong compiler to use for  
> the ROM build.  For instance, if you were on a PPC host building an  
> i386 QEMU package.
>
> Building signrom with HOST_CC may be reasonable.

I'm rather indifferent either way. Shell should work pretty much  
everywhere and it's not really much / highly complex code.

It's also not exactly code I'd want to spend more time on than  
necessary, so if you feel like doing this in C with HOST_CC is better,  
feel free to do so.

Whatever works is fine with me.

Alex