qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] Use ctz64 in favor of ffsll


From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH v2] Use ctz64 in favor of ffsll
Date: Sat, 04 Jul 2009 09:16:40 +0200
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

Paul Brook wrote:
> On Thursday 02 July 2009, Jan Kiszka wrote:
>> Not all host platforms support ffsll.
> 
>> -            pending_irq = i * 64 + bit - 1;
>> +            bit = ctz64(env->interrupt_bitmap[i]);
>> +            pending_irq = i * 64 + bit;
> 
> Are we sure there is only ever one bit set in interrupt_bitmap?

Yes.

> If not does it mater that we're processing them in reverse order?
> 
> Paul

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]