Re: [Qemu-devel] [PATCHv3 1/3] qemu/msi: fix segfault in msix_save

[Blue Swirl]

On 7/5/09, Michael S. Tsirkin <address@hidden> wrote:
> On Sun, Jul 05, 2009 at 11:45:17AM +0100, Stuart Brady wrote:
>  > On Sun, Jul 05, 2009 at 01:24:24PM +0300, Michael S. Tsirkin wrote:
>  > > +    if (!dev->cap_present & QEMU_PCI_CAP_MSIX)
>  > > +        return;
>  >
>  > Same bug as fixed by 98846d7 ('Fix Sparse warning').
>  >
>  > Should be:
>  >
>  >     if (!(dev->cap_present & QEMU_PCI_CAP_MSIX)) {
>  >         return;
>  >     }
>  >
>  > Cheers,
>
>  BTW what's the command to run sparse on qemu?

Just install sparse (sparse and cgcc) somewhere along $PATH, then
configure with --enable-sparse. Rebuild QEMU, sparse will be used as a
wrapper for real GCC.