[Qemu-devel] Re: [COMMIT 707c0db] support colon in filenames

[Ram Pai]

On Sun, 2009-07-05 at 23:47 +0200, Jan Kiszka wrote:
> Jan Kiszka wrote:
> > Anthony,
> > 
> > please revert this patch until Ram Pai provides a better version. It
> > causes too many problems. At least it
Jan,

Yes I am working on the next revision of the patch. 

> > 
> >  - breaks -pflash somefile -snapshot
> 
> Some more details on this: it's not just pflash that suffers, -snapshot
> was broken for raw images in general. Declaring file access as a
> protocol apparently has some unwanted side effects that first have to be
> resolved (check also bdrv_open2 /wrt realpath).

I do not entirely understand the side effect. I will see if I can figure
this out. It will certainly help if you can elaborate more?

> 
> >  - breaks mingw32 build due to redefined _open
> 
> Sorry, this obviously does not apply to the merged revision 2 but to
> rev3 which I had applied locally.
> 
> >  - uses PATH_MAX

PATH_MAX is not defined in mingw32 environment? 

> > 
> > rev3 does not fix any of the above.
> > 
> > At this chance: there is at least one indention issue remaining in
> > fill_token() which would be nice to fix while reworking the patch.
> > 

yes. noted.

Thanks,
RP

> > Jan
> > 
> 
> Jan
>