[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot

From: Avi Kivity
Subject: Re: [Qemu-devel] [PATCH][RESEND] Add monitor command for system_reboot
Date: Wed, 08 Jul 2009 16:11:46 +0300
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 07/08/2009 04:07 PM, Anthony Liguori wrote:
Avi Kivity wrote:
On 07/07/2009 10:26 PM, Ryan Harper wrote:
Add a new monitor command (system_reboot) for a soft reboot which uses
system_powerdown to trigger ACPI shutdown in the guest and once shutdown
is complete, trigger a reset instead of exiting qemu.

Depends on commit a6d6552426dcbf726e5549f08b70c9318d6be14b which enabled
ACPI power button support.

     -added reset handler to lower the reboot flag on reset.

Tested with:
     - Ubuntu 9.04 64-bit guest.
     - SLES 10 SP2 32-bit guest.
     - RHEL 5.3 32 and 64 bit guests.

I think a combination of system_powerdown, avoiding exit on shutdown, and system_reset is more flexible as it allows the controller to modify the guest before rebooting it.

You need notification that the shutdown has occurred. That's the only bit we're missing today. It's still not perfect though.

libvirt does system_powerdown, guest completely ignores it, user decides to power off, libvirt cannot tell the difference between user requested power off and ACPI driven power down.

Does the patch handle this case?

error compiling committee.c: too many arguments to function

reply via email to

[Prev in Thread] Current Thread [Next in Thread]