[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 09/17] pc.c: remove a global variable, RTCState

From: Paolo Bonzini
Subject: [Qemu-devel] Re: [PATCH 09/17] pc.c: remove a global variable, RTCState *rtc_state.
Date: Wed, 08 Jul 2009 09:44:31 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 07/03/2009 09:11 AM, Isaku Yamahata wrote:
+#if defined(TARGET_I386)
  /* set CMOS shutdown status register (index 0xF) as S3_resume(0xFE)
     BIOS will read it and start S3 resume at POST Entry */
+static RTCState *rtc_state;
+void cmos_set_s3_resume_init(RTCState *s)
+    rtc_state = s;
  void cmos_set_s3_resume(void)
      if (rtc_state)
          rtc_set_memory(rtc_state, 0xF, 0xFE);

Comment above the wrong function. Also, rather than defining it only for TARGET_I386, I would #ifdef just the body if cmos_set_s3_resume for cleanliness.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]