[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] Add SCM_RIGHTS support to unix socket chara

From: Jamie Lokier
Subject: Re: [Qemu-devel] [PATCH 2/5] Add SCM_RIGHTS support to unix socket character devices
Date: Sat, 11 Jul 2009 02:15:29 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

Avi Kivity wrote:
> Why impose unnecessary restrictions?  I agree that the guest shouldn't 
> use qemu as an fd store.  But putting such limits in the code is laying 
> a trap for the client, which will show up in rare cases, for example two 
> client threads issuing unrelated getfd commands with the client author 
> not knowing it should serialize them.

If there is an fd queue, then it clearly must be limited on the QEMU
side to avoid becoming an fd store.

A client issuing unrelated commands must be aware of that limitation.
The queue length could be 1, or it could be 10 per monitor to allow
some command overlap, but the client will need to be aware of it and
limit overlap.

That means the limit must be documented in any (future :-) monitor
protocol documentation.

-- Jamie

reply via email to

[Prev in Thread] Current Thread [Next in Thread]