[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Remove dead i386 assembly code from softmmu_hea
Re: [Qemu-devel] [PATCH] Remove dead i386 assembly code from softmmu_header.h
Mon, 13 Jul 2009 01:08:41 +0100
On Sun, Jul 12, 2009 at 08:09:40PM +0100, Stuart Brady wrote:
> This patch removes dead i386 assembly code from softmmu_header.h.
> The code is conditional on ASM_SOFTMMU, which is never defined.
> Optimisation for the fast path is already handled by tcg_out_qemu_ld()
> and tcg_out_qemu_st(), so there seems to be little need for this code.
To answer a question that was put to me off-list, the code in question
is virtually identical to that generated by the i386 tcg_out_qemu_ld()
and tcg_out_qemu_st() functions, with the exception that the TCG
functions also handle loads/stores that are 64-bit and/or big-endian.
 Assuming that tcg_out_qemu_ld() and tcg_out_qemu_st() are commented
correctly -- I didn't actually check the generated machine code, but
I've no particular reason to distrust it.