[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-io: Fix parsing of pattern arguments
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-io: Fix parsing of pattern arguments |
Date: |
Tue, 14 Jul 2009 23:29:01 +0200 |
User-agent: |
Mozilla-Thunderbird 2.0.0.22 (X11/20090707) |
Christoph Hellwig schrieb:
> On Sat, Jul 11, 2009 at 02:35:44PM +0200, Stefan Weil wrote:
>
>> atoi won't parse sedecimal pattern values (it always returns 0).
>> The qemu-iotests use such pattern values, to strtol is needed
>> to get correct results.
>>
>
> Indeed. But now that we're using strtol which can return useful
> errors I think we should also handle those errors. Can you respin
> the patch with that error handling added?
Yes, but I'll finish the vdi driver first, so an improved patch will
have to wait a little.
I'd prefer to see the current version of the patch applied as
first step.
Regards,
Stefan