[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] 2nd try: [PATCH] fix for bad macaddr of e1000 in Window
From: |
Naphtali Sprei |
Subject: |
Re: [Qemu-devel] 2nd try: [PATCH] fix for bad macaddr of e1000 in Windows 2003 server with original Microsoft driver |
Date: |
Thu, 16 Jul 2009 18:17:53 +0300 |
User-agent: |
Thunderbird 2.0.0.22 (X11/20090608) |
comment format changed, (hopefully) fixed mailer wrapping.
Subject: [PATCH] fix for bad macaddr of e1000 in Windows 2003 server with
original Microsoft driver
The sequence of reading from eeprom is "offset by one" moved because of a false
detection
of a clock cycle after an eeprom reset. Keeping the last clock value after a
reset keeps it in sync.
Signed-off-by: Naphtali Sprei <address@hidden>
---
hw/e1000.c | 5 +++++
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/hw/e1000.c b/hw/e1000.c
index 4ac8918..b819501 100644
--- a/hw/e1000.c
+++ b/hw/e1000.c
@@ -262,6 +262,11 @@ set_eecd(E1000State *s, int index, uint32_t val)
}
if (!(val & E1000_EECD_CS)) { // rising, no CS (EEPROM reset)
memset(&s->eecd_state, 0, sizeof s->eecd_state);
+ /*
+ * restore old_eecd's E1000_EECD_SK (known to be on)
+ * to avoid false detection of a clock edge
+ */
+ s->eecd_state.old_eecd = E1000_EECD_SK;
return;
}
s->eecd_state.val_in <<= 1;
--
1.5.5.6