[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 5/5] switch -drive to QemuOpts.

From: Gerd Hoffmann
Subject: Re: [Qemu-devel] [PATCH v3 5/5] switch -drive to QemuOpts.
Date: Thu, 16 Jul 2009 21:32:32 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Lightning/1.0pre Thunderbird/3.0b2

On 07/16/09 21:03, Anthony Liguori wrote:
Gerd Hoffmann wrote:
Quick fix (incremental) attached.
Oh, and a leftover debug line ...

Great, wait a day or two and please resend the series.

I'll be offline tomorrow, weekend and monday next week, so I can have a closer look tuesday (merge bugfix, rebase, fixup whatever shows up).

One thing that bothers me is that there is a really high rate of change
in the qdev stuff. These series touch a lot of code and therefore cause
quite a lot of conflicts. That concerns me that the long term
maintenance of stable-0.11 is going to be really painful.

The by far worst offender is the property refactoring, and that one has seen no fundamental changes since quite a while. Lots of little tweaks though, mostly due to conflicts and due to devices being converted to udev introducing build failures.

btw: blueswirl converted more sparc stuff to qdev, thus adding more build failures with the property rework patch applied. http://git.et.redhat.com/?p=qemu-kraxel.git;a=shortlog;h=refs/heads/qdev.v13 has fixes (four topmost patches), you might want to cherry pick them if you find your tree not building.

All other patches are not *that* intrusive.

So I'm thinking of making an exception for some of the more intrusive
qdev changes and to continue pulling some of them in post freeze. It
would have to be handled on a case by case basis but I'm specifically
thinking of things like the Property refactoring you just did.

I see the property refactoring in your queue already.
And, yes, having that in 0.11 will most likely simplify backports alot.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]