qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 01/14] GPIO rotary encoder implementation


From: Filip Navara
Subject: Re: [Qemu-devel] [PATCH 01/14] GPIO rotary encoder implementation
Date: Sat, 18 Jul 2009 17:26:29 +0200

On Sat, Jul 18, 2009 at 11:00 AM, Blue Swirl<address@hidden> wrote:
> On Sat, Jul 18, 2009 at 11:52 AM, Filip Navara<address@hidden> wrote:
>> On Wed, Jul 15, 2009 at 5:38 PM, Filip Navara<address@hidden> wrote:
>>> On Wed, Jul 15, 2009 at 5:33 PM, Blue Swirl<address@hidden> wrote:
>>>> On Wed, 15 Jul 09 16:52:12 Central Europe Standard Time, Filip Navara
>>>> <address@hidden> wrote:
>>>>> This patch introduces an emulation of the rotary encoder that could be 
>>>>> connected
>>>>>  to GPIO controller.
>>>>
>>>> How about reset handling (qemu_register_reset)?
>>>>
>>>
>>> Good point, it was on my TODO list, but I never implemented it. All
>>> the devices currently lack it. I'll include it in next version.
>>
>> On second thought the GPIO devices don't need reset handling. In real
>> hardware the rotary encoder is not affected by reset, so why would it
>> be affected in QEMU? Unfortunately to get that working correctly the
>> late_init callbacks, proposed in the devtree patches, are needed.
>
> There is still internal state (for example s->extension) that may need reset.
>

s->extension is part of host state actually and I don't think it
should be reset. The only emulated device that resets it is ESCC.
ADB, Musicpal, Syborg, Stellaris and xenfb never reset it (possibly
because reset callbacks are not implemented).

Best regards,
Filip Navara




reply via email to

[Prev in Thread] Current Thread [Next in Thread]