[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] update server bits on vnc_update

From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH] update server bits on vnc_update
Date: Sat, 18 Jul 2009 11:20:54 -0500
User-agent: Thunderbird (X11/20090320)

Glauber Costa wrote:
Since the server/guest split in vnc architecture, we
no longer update the server bits on large updates. Result
is screen gets garbled, specially on scroll actions.

I must admit I don't fully understand our vnc code, but after
a careful reading, it seemed to me the proposed patch would fix
it, and it indeed, works.

Gerd, Anthony, please tell me what you think of this approach.

It seems to look reasonable to me but I'd like Gerd to comment too.

This fixes the following bugs for me:

Very nice.

Signed-off-by: Glauber Costa <address@hidden>
CC: Gerd Hoffmann <address@hidden>
 vnc.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/vnc.c b/vnc.c
index de0ff87..acebdaf 100644
--- a/vnc.c
+++ b/vnc.c
@@ -262,9 +262,8 @@ static inline int vnc_and_bits(const uint32_t *d1, const 
uint32_t *d2,
     return 0;

-static void vnc_update(VncState *vs, int x, int y, int w, int h)
+static void do_vnc_update(struct VncSurface *s, int x, int y, int w, int h)
-    struct VncSurface *s = &vs->guest;

Not worth spinning a new patch, but it's nice to avoid these sort of changes in a bug fix.


Anthony Liguori

reply via email to

[Prev in Thread] Current Thread [Next in Thread]