qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property typ


From: Anthony Liguori
Subject: [Qemu-devel] Re: [PATCH 1/2] Introduce CharDriverState qdev property type
Date: Tue, 21 Jul 2009 10:47:27 -0500
User-agent: Thunderbird 2.0.0.21 (X11/20090320)

Gerd Hoffmann wrote:
On 07/21/09 17:23, Anthony Liguori wrote:
Gerd Hoffmann wrote:
Would you have a property type that was basically a char driver state
name?

Yes. Same for drives and others. A generic string property should do I
think.

Couldn't a struct pointer be used for that though? It can still be
exposed as a string to the user.

Hmm, didn't think about that possibility. Somehow makes sense as it would move the lookup-by-name into generic code (i.e. qemu_prop_chardev->parse).

Not sure what qdev_prop_set_chrdev() should accept then. struct pointer? string?

Good question. I think it depends on how we connect things. We could introduce another structure for front-ends and then have a separate connect mechanism. The association of names would be transparent to qdev/devices.

We could also hand the chrdev structure directly to the device but then you have to deal with setting/unsetting. I think the front-end/back-end structure split is the most appealing.

cheers,
  Gerd



--
Regards,

Anthony Liguori





reply via email to

[Prev in Thread] Current Thread [Next in Thread]