[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct
From: |
Hollis Blanchard |
Subject: |
Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct |
Date: |
Wed, 22 Jul 2009 09:26:14 -0700 |
On Wed, 2009-07-22 at 11:22 -0500, Anthony Liguori wrote:
> Hollis Blanchard wrote:
> > On Wed, 2009-07-22 at 10:34 -0500, Anthony Liguori wrote:
> >
> >> Alexander Graf wrote:
> >>
> >>> Some generic code tries to access env->mp_state. Let's just make
> >>> it happy and provide it.
> >>>
> >>> Signed-off-by: Alexander Graf <address@hidden>
> >>>
> >>>
> >> Or we can move that code from kvm-all.c to target-i386/kvm.c where it
> >> belongs :-)
> >>
> >
> > Common code uses mp_state, and i386 is the only thing calling that code.
> > However, the ioctl used by that code is valid for all architectures; it
> > will just return -EINVAL. Someday we might need it in common code, but
> > then again it's not even clear to me it will be useful outside of x86.
> >
> > I'm fine with moving it too, as long as it's also renamed at the same
> > time. :)
> >
>
> Why is it a common ioctl instead of an arch specific ioctl?
I can only speculate: Marcelo probably thought other architectures may
have something useful to put there.
--
Hollis Blanchard
IBM Linux Technology Center
- [Qemu-devel] Re: [PATCH 7/7] Fake dirty loggin when it's not there, (continued)
- [Qemu-devel] Re: [PATCH 7/7] Fake dirty loggin when it's not there, Jan Kiszka, 2009/07/17
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, Jan Kiszka, 2009/07/17
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, Alexander Graf, 2009/07/17
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, Jan Kiszka, 2009/07/17
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, Alexander Graf, 2009/07/17
- [Qemu-devel] Re: [PATCH 6/7] Set slots more carefully, Jan Kiszka, 2009/07/17
- Re: [Qemu-devel] [PATCH 6/7] Set slots more carefully, Anthony Liguori, 2009/07/21
- Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct, Anthony Liguori, 2009/07/22
- Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct, Hollis Blanchard, 2009/07/22
- Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct, Anthony Liguori, 2009/07/22
- Re: [Qemu-devel] [PATCH 3/7] Add mp_state to PPC CPU struct,
Hollis Blanchard <=
- [Qemu-devel] Re: [PATCH 3/7] Add mp_state to PPC CPU struct, Jan Kiszka, 2009/07/22
- [Qemu-devel] Re: [PATCH 3/7] Add mp_state to PPC CPU struct, Anthony Liguori, 2009/07/22
- [Qemu-devel] Re: [PATCH 3/7] Add mp_state to PPC CPU struct, Jan Kiszka, 2009/07/22
[Qemu-devel] Re: [PATCH 0/4] Add preliminary KVM support for non-embedded PPC v3, Hollis Blanchard, 2009/07/21